Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapted the iOS build for simulators on M1 #588

Merged
merged 4 commits into from
Apr 9, 2022

Conversation

norbertschuler
Copy link
Collaborator

@norbertschuler norbertschuler commented Mar 8, 2022

Fixes #

Changes in this pull request:

  • I needed this to be able to run the app on my M1 with the simulator - not sure if it breaks other build processes.
  • npm install does not work any more due to dependency issues - until we upgrade the package I changed the builds towards using npm install --legacy-peer-deps.

@norbertschuler norbertschuler force-pushed the feature/adapt_build_for_M1 branch from c46c1aa to ee54c6c Compare March 8, 2022 11:14
@norbertschuler norbertschuler force-pushed the feature/adapt_build_for_M1 branch from ee54c6c to c85c8b3 Compare March 8, 2022 11:17
@norbertschuler norbertschuler marked this pull request as ready for review March 26, 2022 10:03
@norbertschuler norbertschuler marked this pull request as draft March 26, 2022 15:44
@norbertschuler
Copy link
Collaborator Author

norbertschuler commented Mar 26, 2022

On my local machine the build is currently crashing because of Mapbox in the iOS simulator. The issue seems to be already known: rnmapbox/maps#1792.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@norbertschuler norbertschuler marked this pull request as ready for review April 9, 2022 11:25
@norbertschuler norbertschuler merged commit 0162ce7 into develop Apr 9, 2022
@norbertschuler norbertschuler deleted the feature/adapt_build_for_M1 branch April 9, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant