refactor(type): replace 'any' with generic type in POST request.

Plant-for-the-Planet-org · Jan 17, 2025 · afb42e3 · afb42e3
1 parent f91b377
commit afb42e3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/src/features/user/CompleteSignup/index.tsx b/src/features/user/CompleteSignup/index.tsx
@@ -178,7 +178,7 @@ export default function CompleteSignup(): ReactElement | null {
     setRequestSent(true);
     setIsProcessing(true);
     try {
-      const res = await postRequest<User>({
+      const res = await postRequest<User, CreateUserRequest>({
         tenant: tenantConfig?.id,
         url: `/app/profile`,
         data: bodyToSend,

diff --git a/src/features/user/TreeMapper/MySpecies/SpeciesAutoComplete.tsx b/src/features/user/TreeMapper/MySpecies/SpeciesAutoComplete.tsx
@@ -25,7 +25,10 @@ interface Props<
   helperText?: React.ReactNode;
   // mySpecies?: any;
 }
-
+type SubmitData = {
+  q: string;
+  t: 'species';
+};
 export default function SpeciesSelect<
   TFieldValues extends FieldValues,
   TName extends FieldPath<TFieldValues>
@@ -62,7 +65,7 @@ export default function SpeciesSelect<
     // Todo: debouncing
     if (value.length > 2) {
       try {
-        const res = await postRequest<SpeciesSuggestionType[]>({
+        const res = await postRequest<SpeciesSuggestionType[], SubmitData>({
           tenant: tenantConfig?.id,
           url: `/suggest.php`,
           data: {

diff --git a/src/utils/apiRequests/api.ts b/src/utils/apiRequests/api.ts
@@ -41,8 +41,8 @@ interface PutAuthRequestOptions<D> extends BaseRequestOptions {
   data?: D;
   logoutUser: (value?: string | undefined) => void;
 }
-interface PostRequestOptions extends BaseRequestOptions {
-  data: any;
+interface PostRequestOptions<D> extends BaseRequestOptions {
+  data: D;
 }
 interface GetRequestOptions extends BaseRequestOptions {
   queryParams?: { [key: string]: string };
@@ -221,7 +221,11 @@ export function postAuthenticatedRequest<T, D = unknown>({
   });
 }
 
-export function postRequest<T>({ tenant, url, data }: PostRequestOptions) {
+export function postRequest<T, D = unknown>({
+  tenant,
+  url,
+  data,
+}: PostRequestOptions<D>) {
   const lang = localStorage.getItem('language') || 'en';
   return new Promise<T>((resolve, reject) => {
     (async () => {