Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds "transfer" as alias to "offline" method #392

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Adds "transfer" as alias to "offline" method #392

wants to merge 1 commit into from
+4 −3

Conversation

mohitb35
Copy link
Contributor

@mohitb35 mohitb35 commented Mar 14, 2023 •
edited
Loading

This is preparation to replace payment method offline with transfer so that the app does not break while transitioning the backend.

  1. Updates condition to display bank transfer as a payment option - it will show up if /app/paymentOptions returns recurrency.methods containing either offline or transfer
  2. Sends transfer as method instead of offline while paying via bank transfer.
  3. Updates payDonationFunction() to handle transfer and offline methods in the same manner.

@mohitb35
feat: adds "transfer" as alias to "offline" method
9e012b3 
- this is preparation to replace method "offline" with "transfer"
@vercel
Copy link

vercel bot commented Mar 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
donate-with-planet ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 5:07AM (UTC)

@mariahosfeld
Copy link
Contributor

Tried one-time and recurrent via bank transfer, both working.

@mohitb35
Copy link
Contributor Author

@jmiridis Can this be released, or do some backend changes need to go out first?

@mohitb35 mohitb35 added the blocked Should not be merged label May 2, 2023
@mohitb35
Copy link
Contributor Author

mohitb35 commented May 2, 2023

Blocked currently as some backend changes are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmiridis jmiridis Awaiting requested review from jmiridis

@sunilsabatp sunilsabatp Awaiting requested review from sunilsabatp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked Should not be merged PR: unreviewed Should we close this?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohitb35 @mariahosfeld @jmiridis @norbertschuler