Add gffread EXTRACT_CDNA and EXTRACT_CDS feature to outputs #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch-Open/dev Candidate for 0.5.0
Correct indents and whitespaces
This comment was marked as resolved.
This comment was marked as resolved.
GallVp
reviewed
Dec 4, 2024
GallVp
reviewed
Dec 4, 2024
GallVp
reviewed
Dec 4, 2024
This comment was marked as resolved.
This comment was marked as resolved.
removed end of line "/"
This comment was marked as resolved.
This comment was marked as resolved.
params.add_attrs_to_proteins_fasta to params.add_attrs_to_gffread_fastas
Rename params.add_attrs_to_proteins_fasta to params.add_attrs_to_gffread_fastas
GallVp
reviewed
Dec 4, 2024
GallVp
reviewed
Dec 4, 2024
|
I think all the issues have been resolved. To fix the pre-commit, I just had to rerun it on my system. I don't know why it was failing for you. Please feel free to merge the PR, once all the tests have passed! Thank you again for your contribution and going through the hassle. Hopefully, the things you have picked up here will help you contribute to any nf-core pipeline in the future. |
GallVp
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #118, added additional Y.cdna.fasta and Y.cds.fasta outputs to the output dir annotations directory to the pipeline. These output files are useful for downstream tools like SNPEff.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).