Skip to content

Commit

Permalink
Merge pull request #633 from ChicagoWorldcon/staging
Browse files Browse the repository at this point in the history
Staging to main for brakeman
  • Loading branch information
balen authored Aug 14, 2022
2 parents 2fd4e1f + f42657f commit fecc2d2
Showing 1 changed file with 22 additions and 2 deletions.
24 changes: 22 additions & 2 deletions config/brakeman.ignore
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"check_name": "MassAssignment",
"message": "Specify exact keys allowed for mass assignment instead of using `permit!` which allows any keys",
"file": "app/controllers/concerns/resource_methods.rb",
"line": 746,
"line": 759,
"link": "https://brakemanscanner.org/docs/warning_types/mass_assignment/",
"code": "params.require(model).permit!",
"render_path": null,
Expand All @@ -100,6 +100,26 @@
"confidence": "Medium",
"note": ""
},
{
"warning_type": "Unscoped Find",
"warning_code": 82,
"fingerprint": "6febff74984a127219272fbf1045466f8d4580b045abcccb8873a98cfc025ecd",
"check_name": "UnscopedFind",
"message": "Unscoped call to `Session#find`",
"file": "app/controllers/reports/schedule_reports_controller.rb",
"line": 118,
"link": "https://brakemanscanner.org/docs/warning_types/unscoped_find/",
"code": "Session.find(SessionAssignment.find(change[:session_assignment_id]).session_id)",
"render_path": null,
"location": {
"type": "method",
"class": "Reports::ScheduleReportsController",
"method": "schedule_diff"
},
"user_input": "SessionAssignment.find(change[:session_assignment_id]).session_id",
"confidence": "Weak",
"note": ""
},
{
"warning_type": "Unscoped Find",
"warning_code": 82,
Expand Down Expand Up @@ -161,6 +181,6 @@
"note": ""
}
],
"updated": "2022-07-21 20:13:36 -0400",
"updated": "2022-08-14 17:55:37 -0400",
"brakeman_version": "5.2.3"
}

0 comments on commit fecc2d2

Please sign in to comment.