Fix parameter links

Safer code in serializer
PlanoramaEvents · Nov 30, 2023 · 1581d23 · 1581d23
1 parent 49d2d0f
commit 1581d23
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/controllers/schedule_controller.rb b/app/controllers/schedule_controller.rb
@@ -28,7 +28,7 @@ class ScheduleController < ApplicationController
   # end
 
   def index
-    links = params.permit(:links)
+    links = params.permit(:links)[:links]
 
     serializer = links ? Conclar::SessionSerializerWithLinks : Conclar::SessionSerializer
     sessions = SessionService.scheduled_sessions

diff --git a/app/serializers/conclar/session_serializer_with_links.rb b/app/serializers/conclar/session_serializer_with_links.rb
@@ -14,7 +14,11 @@ class Conclar::SessionSerializerWithLinks < ActiveModel::Serializer
   end
 
   attribute :desc do
-    "#{object.description}<p><a href=\"#{object.integrations.dig('smofcon', 'link')}\" target=\"_blank\">Click here to view</a></p>"
+    if object.integrations
+      "#{object.description}<p><a href=\"#{object.integrations.dig('smofcon', 'link')}\" target=\"_blank\">Click here to view</a></p>"
+    else
+      object.description
+    end
   end
 
   attribute :datetime do