Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pxrTargets.cmake relocatable (when built with TBB and OpenSubdiv) #3441

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

tamaskenez
Copy link

@tamaskenez tamaskenez commented Nov 30, 2024

Description of Change(s)

The CMake targets now use TBB and OpenSubdiv as targets instead of absolute include and library paths.

Link to proposal (if applicable)

Fixes Issue(s)

The installed OpenUSD library was not relocatable because cmake/pxrTargets.cmake contained absolute paths of include directories and library files.

This PR solves the issue partially: it changes the way oneTBB and OpenSubdiv are used, if those dependencies are found by their CMake config-scripts (as opposed to a find-module).

Therefore, if OpenUSD is built only with the oneTBB (not the old TBB) and OpenSubdiv dependencies which provide a config-script (which is the case when building with build_usd.py), with this PR the installed OpenSubdiv library will be relocatable.

Checklist

[X] I have created this PR based on the dev branch

[X] I have followed the coding conventions

[ ] I have added unit tests that exercise this functionality (Reference:
testing guidelines)

[ ] I have verified that all unit tests pass with the proposed changes

[ ] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)

@tamaskenez tamaskenez changed the title Make TBB and OpenSubdiv dependencies relocatable Make pxrTargets.cmake relocatable (when built with TBB and OpenSubdiv) Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants