Autodesk: Skip use of geometry shader for patch tessellation when possible #3422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This updates the shader configuration for surface patches, for better performance. The geometry shader is in most cases omitted except when the display style is HdMeshGeomStyleEdgeOnSurf, in which case a geometry shader is required to render edges of output triangles.
The changes include new tessellation evaluation shaders, and an alternative DisplacementTerminal protocol in order to evaluate displacements correctly in a tessellation shader. Some changes also in codegen to include required supporting code such as interstage elements. Also included here is a TfDebug variable for listing shader keys.
Performance tests indicate approximately 40% speedup on average when rendering this type of geometry on a high-end laptop with an NVidia RTX A3000 GPU.
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)