Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented create magic url #71

Merged
merged 9 commits into from
Jul 13, 2024
Merged

Implemented create magic url #71

merged 9 commits into from
Jul 13, 2024

Conversation

pingu2k4
Copy link
Contributor

Changes

Implemented create magic url

Issue

#45

Checklist before requesting a review

The PR will only be considered when all items within the checklist are marked as complete. Feel free to submit an incomplete draft PR, and add additional commits until you are able to satisfy each item within the checklist.

  • I have performed a self-review of my code
  • I have submitted at most one additional endpoint implementation
  • I have either submitted no additional endpoint implementation, or my implementation covers both client and server SDK's, unless either are marked in the README with a ❌
  • I have added applicable tests for my code
  • I have updated the README with updated status as a result of this PR

@pingu2k4 pingu2k4 self-assigned this Jul 13, 2024
@pingu2k4 pingu2k4 linked an issue Jul 13, 2024 that may be closed by this pull request
namespace PinguApps.Appwrite.Shared.Tests.Responses;
public class TokenTests
{

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An opening brace should not be followed by a blank line.

Suggested change

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 93% 37
PinguApps.Appwrite.Server 100% 90% 19
PinguApps.Appwrite.Shared 100% 100% 87
Summary 100% (251 / 251) 94% (30 / 32) 143

Copy link

Test Results

147 tests  +22   147 ✅ +22   3s ⏱️ ±0s
  3 suites ± 0     0 💤 ± 0 
  3 files   ± 0     0 ❌ ± 0 

Results for commit a791860. ± Comparison against base commit fff9ed9.

@pingu2k4 pingu2k4 merged commit 2575002 into dev Jul 13, 2024
3 checks passed
@pingu2k4 pingu2k4 deleted the 45-create-magic-url branch July 13, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Account - Create Magic URL implementation
2 participants