-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented all documents endpoints #557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, session is added
Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use |
Test Results3 652 tests +50 3 652 ✅ +50 26s ⏱️ ±0s Results for commit 7cb674e. ± Comparison against base commit c929cf8. This pull request removes 342 and adds 392 tests. Note that renamed tests count towards both.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issue
Categorise the PR
feature
bug
docs
security
meta
patch
minor
major
Description by Korbit AI
What change is being made?
Implement all CRUD endpoints for documents within the database client, including corresponding tests and updates to the README progress indicators.
Why are these changes being made?
This change addresses the integration of document-level operations, allowing users to list, create, update, fetch, and delete documents within collections. Implementing these endpoints fills a critical gap in the client functionality, provides a complete interface for document manipulation, and aligns with backend capabilities. Some adjustments in exception handling facilitate robustness and error management, and comprehensive tests ensure reliability.