Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented update database #551

Merged
merged 17 commits into from
Nov 28, 2024
Merged

Implemented update database #551

merged 17 commits into from
Nov 28, 2024

Conversation

pingu2k4
Copy link
Contributor

@pingu2k4 pingu2k4 commented Nov 28, 2024

Changes

  • Implemented update database

Issue

Categorise the PR

  • feature
  • bug
  • docs
  • security
  • meta
  • patch
  • minor
  • major

Description by Korbit AI

What change is being made?

Implement Database update functionality alongside adding various database collection management operations including create, list, update, and delete functionality for collections and attributes in the Appwrite server client library, with corresponding test coverage.

Why are these changes being made?

These changes are implemented to add the ability to manage databases comprehensively through the server client, reflecting API capabilities and reducing the amount of unimplemented functionality. By adding these functionalities, client applications can programmatically manage database collections and attributes, which was previously unavailable, thereby enhancing the database management scope of the Appwrite server client library. Tests ensure reliability and robustness of these new functionalities.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

@pingu2k4 pingu2k4 self-assigned this Nov 28, 2024
@pingu2k4 pingu2k4 linked an issue Nov 28, 2024 that may be closed by this pull request
Copy link

korbit-ai bot commented Nov 28, 2024

Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 100% 131
PinguApps.Appwrite.Server 100% 100% 120
PinguApps.Appwrite.Shared 100% 100% 1317
Summary 100% (3431 / 3432) 100% (651 / 653) 1568

Copy link

Test Results

3 526 tests  +26   3 526 ✅ +26   23s ⏱️ +2s
    3 suites ± 0       0 💤 ± 0 
    3 files   ± 0       0 ❌ ± 0 

Results for commit 3d7e0d0. ± Comparison against base commit 663a9ff.

This pull request removes 340 and adds 366 tests. Note that renamed tests count towards both.
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ CreateUserJwt_ShouldReturnSuccess_WhenApiCallSucceeds(request: CreateUserJwtRequest { Duration = 1800, SessionId = "6748b83300093fa28773", UserId = "6748b8330009309665f0", ValidationContext = None })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ CreateUserJwt_ShouldReturnSuccess_WhenApiCallSucceeds(request: CreateUserJwtRequest { Duration = null, SessionId = null, UserId = "6748b83300092fd2601b", ValidationContext = None })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserLogs_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserLogsRequest { Queries = null, UserId = "6748b8330009427525e5", ValidationContext = None })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserLogs_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserLogsRequest { Queries = null, UserId = "6748b83300094fdb60e4", ValidationContext = None })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserTargets_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserTargetsRequest { Queries = null, UserId = "6748b833000946a4a232", ValidationContext = None })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserTargets_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserTargetsRequest { Queries = null, UserId = "6748b83300094d150b71", ValidationContext = None })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ UpdateUserLabels_ShouldReturnSuccess_WhenApiCallSucceeds(request: UpdateUserLabelsRequest { Labels = ["label1", "label2"], UserId = "6748b83300094d99c0be", ValidationContext = None })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ UpdateUserLabels_ShouldReturnSuccess_WhenApiCallSucceeds(request: UpdateUserLabelsRequest { Labels = ["label3", "label4"], UserId = "6748b8330009444c952c", ValidationContext = None })
PinguApps.Appwrite.Shared.Tests.Requests.Account.CreatePushTargetRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreatePushTargetRequest { Identifier = "", ProviderId = "provider123", TargetId = "6748b82c00068cd1f040", ValidationContext = None })
PinguApps.Appwrite.Shared.Tests.Requests.Account.CreatePushTargetRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreatePushTargetRequest { Identifier = null, ProviderId = "provider123", TargetId = "6748b82c00068786f230", ValidationContext = None })
…
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ CreateBooleanAttribute_ShouldHandleException_WhenApiCallFails
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ CreateBooleanAttribute_ShouldReturnErrorResponse_WhenExceptionOccurs
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ CreateBooleanAttribute_ShouldReturnSuccess_WhenApiCallSucceeds
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ CreateCollection_ShouldHandleException_WhenApiCallFails
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ CreateCollection_ShouldReturnErrorResponse_WhenExceptionOccurs
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ CreateCollection_ShouldReturnSuccess_WhenApiCallSucceeds
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ DeleteCollection_ShouldHandleException_WhenApiCallFails
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ DeleteCollection_ShouldReturnErrorResponse_WhenExceptionOccurs
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ DeleteCollection_ShouldReturnSuccess_WhenApiCallSucceeds
PinguApps.Appwrite.Server.Tests.Clients.Databases.DatabasesClientTests ‑ GetCollection_ShouldHandleException_WhenApiCallFails
…

@pingu2k4 pingu2k4 merged commit cf82971 into dev Nov 28, 2024
7 checks passed
@pingu2k4 pingu2k4 deleted the 348-update-database branch November 28, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant