get database #550
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,9 +72,22 @@ public async Task<AppwriteResult> DeleteDatabase(DeleteDatabaseRequest request) | |
| } | ||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public async Task<AppwriteResult<Database>> GetDatabase(GetDatabaseRequest request) | ||
| { | ||
| try | ||
| { | ||
| request.Validate(true); | ||
|
|
||
| var result = await _databasesApi.GetDatabase(request.DatabaseId); | ||
|
|
||
| return result.GetApiResponse(); | ||
| } | ||
| catch (Exception e) | ||
| { | ||
| return e.GetExceptionResponse<Database>(); | ||
| } | ||
|
Comment on lines
+86
to
+89
There was a problem hiding this comment.
Overly broad exception handling Tell me moreWhat is the issue? Why this matters |
||
| } | ||
|
|
||
| [ExcludeFromCodeCoverage] | ||
| /// <inheritdoc/> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| using System.Net; | ||
| using PinguApps.Appwrite.Shared.Requests.Databases; | ||
| using PinguApps.Appwrite.Shared.Tests; | ||
| using PinguApps.Appwrite.Shared.Utils; | ||
| using RichardSzalay.MockHttp; | ||
|
|
||
| namespace PinguApps.Appwrite.Server.Tests.Clients.Databases; | ||
| public partial class DatabasesClientTests | ||
| { | ||
| [Fact] | ||
| public async Task GetDatabase_ShouldReturnSuccess_WhenApiCallSucceeds() | ||
| { | ||
| // Arrange | ||
| var request = new GetDatabaseRequest | ||
| { | ||
| DatabaseId = IdUtils.GenerateUniqueId() | ||
| }; | ||
|
|
||
| _mockHttp.Expect(HttpMethod.Get, $"{TestConstants.Endpoint}/databases/{request.DatabaseId}") | ||
| .ExpectedHeaders() | ||
| .Respond(TestConstants.AppJson, TestConstants.DatabaseResponse); | ||
|
|
||
| // Act | ||
| var result = await _appwriteClient.Databases.GetDatabase(request); | ||
|
|
||
| // Assert | ||
| Assert.True(result.Success); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task GetDatabase_ShouldHandleException_WhenApiCallFails() | ||
| { | ||
| // Arrange | ||
| var request = new GetDatabaseRequest | ||
| { | ||
| DatabaseId = IdUtils.GenerateUniqueId() | ||
| }; | ||
|
|
||
| _mockHttp.Expect(HttpMethod.Get, $"{TestConstants.Endpoint}/databases/{request.DatabaseId}") | ||
| .ExpectedHeaders() | ||
| .Respond(HttpStatusCode.BadRequest, TestConstants.AppJson, TestConstants.AppwriteError); | ||
|
|
||
| // Act | ||
| var result = await _appwriteClient.Databases.GetDatabase(request); | ||
|
|
||
| // Assert | ||
| Assert.True(result.IsError); | ||
| Assert.True(result.IsAppwriteError); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task GetDatabase_ShouldReturnErrorResponse_WhenExceptionOccurs() | ||
| { | ||
| // Arrange | ||
| var request = new GetDatabaseRequest | ||
| { | ||
| DatabaseId = IdUtils.GenerateUniqueId() | ||
| }; | ||
|
|
||
| _mockHttp.Expect(HttpMethod.Get, $"{TestConstants.Endpoint}/databases/{request.DatabaseId}") | ||
| .ExpectedHeaders() | ||
| .Throw(new HttpRequestException("An error occurred")); | ||
|
|
||
| // Act | ||
| var result = await _appwriteClient.Databases.GetDatabase(request); | ||
|
|
||
| // Assert | ||
| Assert.False(result.Success); | ||
| Assert.True(result.IsInternalError); | ||
| Assert.Equal("An error occurred", result.Result.AsT2.Message); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log exception before returning the exception response.
Tell me more
Consider logging the exception before returning the exception response. This will help with debugging and monitoring the application. You can add a logging statement like
_logger.LogError(e, "Error occurred while getting database");before returning the exception response.