Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 2 minor code quality issues #53

Merged
merged 1 commit into from
Jul 7, 2024
Merged

fixed 2 minor code quality issues #53

merged 1 commit into from
Jul 7, 2024

Conversation

pingu2k4
Copy link
Contributor

@pingu2k4 pingu2k4 commented Jul 7, 2024

Changes

fixed 2 minor code quality issues

Issue

#51

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have submitted at most one additional endpoint implementation
  • I have either submitted no additional endpoint implementation, or my implementation covers both client and server SDK's, unless either are marked in the README with a ❌
  • I have added applicable tests for my code
  • I have updated the README with updated status as a result of this PR

@pingu2k4 pingu2k4 self-assigned this Jul 7, 2024
@pingu2k4 pingu2k4 linked an issue Jul 7, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 7, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 93% 30
PinguApps.Appwrite.Server 100% 90% 18
PinguApps.Appwrite.Shared 100% 100% 55
Summary 100% (158 / 158) 92% (24 / 26) 103

Copy link

github-actions bot commented Jul 7, 2024

Test Results

46 tests  ±0   46 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 3 files   ±0    0 ❌ ±0 

Results for commit 1ccbf27. ± Comparison against base commit fab5071.

@pingu2k4 pingu2k4 merged commit 8cf53ce into dev Jul 7, 2024
3 checks passed
@pingu2k4 pingu2k4 deleted the 51-code-quality branch July 7, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Fix code quality issues from codefactor
1 participant