Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created stricter JsonSerialisation rules #291

Merged
merged 7 commits into from
Oct 13, 2024
Merged

Conversation

pingu2k4
Copy link
Contributor

Changes

  • Created stricter JsonSerialisation rules

Issue

#287

Checklist before requesting a review

The PR will only be considered when all items within the checklist are marked as complete. Feel free to submit an incomplete draft PR, and add additional commits until you are able to satisfy each item within the checklist.

  • I have performed a self-review of my code
  • I have submitted at most one additional endpoint implementation
  • I have either submitted no additional endpoint implementation, or my implementation covers both client and server SDK's, unless either are marked in the README with a ❌
  • I have added applicable tests for my code
  • I have updated the README with updated status as a result of this PR

@pingu2k4 pingu2k4 self-assigned this Oct 13, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 100% 112
PinguApps.Appwrite.Server 100% 100% 92
PinguApps.Appwrite.Shared 100% 100% 564
Summary 100% (1727 / 1727) 100% (230 / 230) 768

Copy link

Test Results

1 577 tests  +15   1 577 ✅ +15   8s ⏱️ ±0s
    3 suites ± 0       0 💤 ± 0 
    3 files   ± 0       0 ❌ ± 0 

Results for commit 4ecf688. ± Comparison against base commit a978765.

This pull request removes 166 and adds 181 tests. Note that renamed tests count towards both.
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ CreateUserJwt_ShouldReturnSuccess_WhenApiCallSucceeds(request: CreateUserJwtRequest { Duration = 1800, SessionId = "670ada520033357c26ec", UserId = "670ada52003334cc106a" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ CreateUserJwt_ShouldReturnSuccess_WhenApiCallSucceeds(request: CreateUserJwtRequest { Duration = null, SessionId = null, UserId = "670ada5200332ed3a68c" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserLogs_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserLogsRequest { Queries = null, UserId = "670ada5200333901749c" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserLogs_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserLogsRequest { Queries = null, UserId = "670ada5200333aad10f0" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserTargets_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserTargetsRequest { Queries = null, UserId = "670ada52003332b20a8f" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserTargets_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserTargetsRequest { Queries = null, UserId = "670ada5200333cd71c19" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ UpdateUserLabels_ShouldReturnSuccess_WhenApiCallSucceeds(request: UpdateUserLabelsRequest { Labels = ["label1", "label2"], UserId = "670ada5200333b26f0ed" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ UpdateUserLabels_ShouldReturnSuccess_WhenApiCallSucceeds(request: UpdateUserLabelsRequest { Labels = ["label3", "label4"], UserId = "670ada5200333e58afe5" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreateTokenRequest { Expire = -1, Length = null, UserId = "670ada4e00130412ea10" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreateTokenRequest { Expire = null, Length = -1, UserId = "670ada4e0013090724d5" })
…
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ CreateUserJwt_ShouldReturnSuccess_WhenApiCallSucceeds(request: CreateUserJwtRequest { Duration = 1800, SessionId = "670b2a880031fc3172cf", UserId = "670b2a880031f14c32dc" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ CreateUserJwt_ShouldReturnSuccess_WhenApiCallSucceeds(request: CreateUserJwtRequest { Duration = null, SessionId = null, UserId = "670b2a880031e53e2122" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserLogs_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserLogsRequest { Queries = null, UserId = "670b2a880031f0139f8b" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserLogs_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserLogsRequest { Queries = null, UserId = "670b2a880031fdcecc6e" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserTargets_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserTargetsRequest { Queries = null, UserId = "670b2a8800320464709b" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ ListUserTargets_ShouldReturnSuccess_WhenApiCallSucceeds(request: ListUserTargetsRequest { Queries = null, UserId = "670b2a88003205692512" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ UpdateUserLabels_ShouldReturnSuccess_WhenApiCallSucceeds(request: UpdateUserLabelsRequest { Labels = ["label1", "label2"], UserId = "670b2a88003207caab72" })
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ UpdateUserLabels_ShouldReturnSuccess_WhenApiCallSucceeds(request: UpdateUserLabelsRequest { Labels = ["label3", "label4"], UserId = "670b2a88003200097ac1" })
PinguApps.Appwrite.Shared.Tests.Converters.IgnoreSdkExcludedPropertiesConverterFactoryTests ‑ CanConvert_AbstractClassTypes_ReturnsFalse
PinguApps.Appwrite.Shared.Tests.Converters.IgnoreSdkExcludedPropertiesConverterFactoryTests ‑ CanConvert_ClassTypes_ReturnsTrue
…

@pingu2k4 pingu2k4 merged commit 1d7fc9f into dev Oct 13, 2024
3 checks passed
@pingu2k4 pingu2k4 deleted the 287-requsts-nullable-props branch October 13, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Mark ALL nullable properties in reqyuests with JsonIgnore condition
1 participant