Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented create user for Users API #232

Merged
merged 4 commits into from
Oct 6, 2024
Merged

Conversation

pingu2k4
Copy link
Contributor

@pingu2k4 pingu2k4 commented Oct 6, 2024

Changes

  • Implemented create user for Users API

Issue

#183

Checklist before requesting a review

The PR will only be considered when all items within the checklist are marked as complete. Feel free to submit an incomplete draft PR, and add additional commits until you are able to satisfy each item within the checklist.

  • I have performed a self-review of my code
  • I have submitted at most one additional endpoint implementation
  • I have either submitted no additional endpoint implementation, or my implementation covers both client and server SDK's, unless either are marked in the README with a ❌
  • I have added applicable tests for my code
  • I have updated the README with updated status as a result of this PR

@pingu2k4 pingu2k4 self-assigned this Oct 6, 2024
@pingu2k4 pingu2k4 linked an issue Oct 6, 2024 that may be closed by this pull request
Co-authored-by: codefactor-io[bot] <47775046+codefactor-io[bot]@users.noreply.github.com>
Copy link

github-actions bot commented Oct 6, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 100% 109
PinguApps.Appwrite.Server 100% 100% 48
PinguApps.Appwrite.Shared 100% 100% 507
Summary 100% (1457 / 1457) 100% (164 / 164) 664

Copy link

github-actions bot commented Oct 6, 2024

Test Results

1 429 tests   - 6   1 429 ✅  - 6   7s ⏱️ ±0s
    3 suites ±0       0 💤 ±0 
    3 files   ±0       0 ❌ ±0 

Results for commit 1def6cf. ± Comparison against base commit 095998a.

This pull request removes 173 and adds 167 tests. Note that renamed tests count towards both.
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreateTokenRequest { Expire = -1, Length = null, UserId = "6701b9a200218da861a5" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreateTokenRequest { Expire = null, Length = -1, UserId = "6701b9a20021849da3d6" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithValidData_ReturnsTrue(request: CreateTokenRequest { Expire = 86400, Length = 100, UserId = "6701b9a2002188ca43f2" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithValidData_ReturnsTrue(request: CreateTokenRequest { Expire = 900, Length = 6, UserId = "6701b9a2002171e3680e" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateUserRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(email: "", phone: null, password: null, name: null)
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateUserRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(email: "not an email", phone: null, password: null, name: null)
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateUserRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(email: null, phone: "", password: null, name: null)
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateUserRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(email: null, phone: "+1234567890123456789", password: null, name: null)
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateUserRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(email: null, phone: "+456123!!!", password: null, name: null)
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateUserRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(email: null, phone: "+456123aaa", password: null, name: null)
…
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ CreateUser_ShouldHandleException_WhenApiCallFails
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ CreateUser_ShouldReturnErrorResponse_WhenExceptionOccurs
PinguApps.Appwrite.Server.Tests.Clients.Users.UsersClientTests ‑ CreateUser_ShouldReturnSuccess_WhenApiCallSucceeds
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreateTokenRequest { Expire = -1, Length = null, UserId = "6701e1ec001c2c95aacc" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreateTokenRequest { Expire = null, Length = -1, UserId = "6701e1ec001c27e91eed" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithValidData_ReturnsTrue(request: CreateTokenRequest { Expire = 86400, Length = 100, UserId = "6701e1ec001c229f1c76" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateTokenRequestTests ‑ IsValid_WithValidData_ReturnsTrue(request: CreateTokenRequest { Expire = 900, Length = 6, UserId = "6701e1ec001c0c12e7b6" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateUserRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreateUserRequest { Email = "", Name = null, Password = null, Phone = null, UserId = "6701e1ec001c78fa6959" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateUserRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreateUserRequest { Email = "not an email", Name = null, Password = null, Phone = null, UserId = "6701e1ec001c7374323d" })
PinguApps.Appwrite.Shared.Tests.Requests.Users.CreateUserRequestTests ‑ IsValid_WithInvalidData_ReturnsFalse(request: CreateUserRequest { Email = null, Name = "", Password = null, Phone = null, UserId = "6701e1ec001c7db9cec5" })
…

@pingu2k4 pingu2k4 merged commit 45ab671 into dev Oct 6, 2024
3 checks passed
@pingu2k4 pingu2k4 deleted the 183-users-create-user branch October 6, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Implement Users - Create User
1 participant