Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented create 2fa challenge confirmation #124

Merged
merged 7 commits into from
Aug 10, 2024

Conversation

pingu2k4
Copy link
Contributor

Changes

  • Implemented create 2fa challenge confirmation
  • Changed how we handle session

Issue

#91

Checklist before requesting a review

The PR will only be considered when all items within the checklist are marked as complete. Feel free to submit an incomplete draft PR, and add additional commits until you are able to satisfy each item within the checklist.

  • I have performed a self-review of my code
  • I have submitted at most one additional endpoint implementation
  • I have either submitted no additional endpoint implementation, or my implementation covers both client and server SDK's, unless either are marked in the README with a ❌
  • I have added applicable tests for my code
  • I have updated the README with updated status as a result of this PR

@pingu2k4 pingu2k4 self-assigned this Aug 10, 2024
@pingu2k4 pingu2k4 linked an issue Aug 10, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 10, 2024

Test Results

370 tests  +33   370 ✅ +33   4s ⏱️ ±0s
  3 suites ± 0     0 💤 ± 0 
  3 files   ± 0     0 ❌ ± 0 

Results for commit cd6d39b. ± Comparison against base commit 6f1791b.

♻️ This comment has been updated with latest results.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 100% 84
PinguApps.Appwrite.Server 100% 100% 28
PinguApps.Appwrite.Shared 100% 100% 235
Summary 100% (557 / 557) 100% (90 / 90) 347

@pingu2k4 pingu2k4 merged commit 2333895 into dev Aug 10, 2024
3 checks passed
@pingu2k4 pingu2k4 deleted the 91-create-2fa-challenge-confirmation branch August 10, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Account - Create 2FA Challenge Confirmation
1 participant