Merge pull request #74 from PinguApps/73-session-handler-unsuccessful…

…-responses Removed condition that we need to have a successful response to change cookies
PinguApps · Jul 16, 2024 · 490e315 · 490e315
2 parents 7848520 + 693e601
commit 490e315
Showing 1 changed file with 23 additions and 26 deletions.
diff --git a/src/PinguApps.Appwrite.Client/Handlers/ClientCookieSessionHandler.cs b/src/PinguApps.Appwrite.Client/Handlers/ClientCookieSessionHandler.cs
@@ -30,40 +30,37 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
 
     private void SaveSession(HttpResponseMessage response)
     {
-        if (response.IsSuccessStatusCode)
+        if (response.Headers.TryGetValues("Set-Cookie", out var values))
         {
-            if (response.Headers.TryGetValues("Set-Cookie", out var values))
-            {
-                var sessionCookie = values.FirstOrDefault(x => x.StartsWith("a_session", StringComparison.OrdinalIgnoreCase) && !x.Contains("legacy", StringComparison.OrdinalIgnoreCase));
+            var sessionCookie = values.FirstOrDefault(x => x.StartsWith("a_session", StringComparison.OrdinalIgnoreCase) && !x.Contains("legacy", StringComparison.OrdinalIgnoreCase));
 
-                if (sessionCookie is null)
-                    return;
+            if (sessionCookie is null)
+                return;
 
-                var afterEquals = sessionCookie.IndexOf('=') + 1;
-                var semicolonIndex = sessionCookie.IndexOf(';', afterEquals);
-                var base64 = sessionCookie.Substring(afterEquals, semicolonIndex - afterEquals);
+            var afterEquals = sessionCookie.IndexOf('=') + 1;
+            var semicolonIndex = sessionCookie.IndexOf(';', afterEquals);
+            var base64 = sessionCookie.Substring(afterEquals, semicolonIndex - afterEquals);
 
-                if (string.Equals(base64, "deleted", StringComparison.OrdinalIgnoreCase))
-                {
-                    AppwriteClient.SetSession(null);
-                    return;
-                }
+            if (string.Equals(base64, "deleted", StringComparison.OrdinalIgnoreCase))
+            {
+                AppwriteClient.SetSession(null);
+                return;
+            }
 
-                var decodedBytes = Convert.FromBase64String(base64);
-                var decoded = Encoding.UTF8.GetString(decodedBytes);
+            var decodedBytes = Convert.FromBase64String(base64);
+            var decoded = Encoding.UTF8.GetString(decodedBytes);
 
-                try
-                {
-                    var sessionData = JsonSerializer.Deserialize<CookieSessionData>(decoded);
+            try
+            {
+                var sessionData = JsonSerializer.Deserialize<CookieSessionData>(decoded);
 
-                    if (sessionData is null || sessionData.Id is null || sessionData.Secret is null)
-                        return;
+                if (sessionData is null || sessionData.Id is null || sessionData.Secret is null)
+                    return;
 
-                    AppwriteClient.SetSession(sessionData.Secret);
-                }
-                catch (JsonException)
-                {
-                }
+                AppwriteClient.SetSession(sessionData.Secret);
+            }
+            catch (JsonException)
+            {
             }
         }
     }