Skip to content

Commit

Permalink
Fix CI concurrency (valkey-io#849)
Browse files Browse the repository at this point in the history
Few CI improvements witch will reduce occupation CI queue and eliminate
stale runs.

1. Kill CI jobs on PRs once PR branch gets a new push. This will prevent
situation happened today - a huge job triggered twice in less than an
hour and occupied all **org** (for all repositories) runners queue for
the rest of the day (see pic). This completely blocked valkey-glide
team.
2. Distribute nightly croned jobs on time to prevent them running
together. Keep in mind, cron's TZ is UTC, so midnight tasks incur
developers located in other timezones.

This must be backported to all release branches (`valkey-x.y` and `x.y`)

![image](https://github.com/user-attachments/assets/923d8237-3cb7-42f5-80c8-5322b3f5187d)

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
  • Loading branch information
Yury-Fridlyand authored Aug 6, 2024
1 parent 0fc43ed commit bfdab65
Show file tree
Hide file tree
Showing 9 changed files with 41 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ name: CI

on: [push, pull_request]

concurrency:
group: ci-${{ github.head_ref || github.ref }}
cancel-in-progress: true

permissions:
contents: read

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/clang-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
paths:
- 'src/**'

concurrency:
group: clang-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
clang-format-check:
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ name: "Codecov"
# where each PR needs to be compared against the coverage of the head commit
on: [push, pull_request]

concurrency:
group: codecov-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
code-coverage:
runs-on: ubuntu-latest
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ on:
pull_request:
schedule:
# run weekly new vulnerability was added to the database
- cron: '0 0 * * 0'
- cron: '0 3 * * 0'

concurrency:
group: codeql-${{ github.head_ref || github.ref }}
cancel-in-progress: true

permissions:
contents: read
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/coverity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,17 @@ name: Coverity Scan
on:
schedule:
# Run once daily, since below 500k LOC can have 21 builds per week, per https://scan.coverity.com/faq#frequency
- cron: '0 0 * * *'
- cron: '0 1 * * *'
# Support manual execution
workflow_dispatch:

concurrency:
group: coverity-${{ github.head_ref || github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
coverity:
if: github.repository == 'valkey-io/valkey'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ on:
description: "git branch or sha to use"
default: "unstable"

concurrency:
group: daily-${{ github.head_ref || github.ref }}
cancel-in-progress: true

permissions:
contents: read

Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/external.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ on:
pull_request:
push:
schedule:
- cron: '0 0 * * *'
- cron: '0 2 * * *'

concurrency:
group: external-${{ github.head_ref || github.ref }}
cancel-in-progress: true

permissions:
contents: read
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/reply-schemas-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ on:
paths:
- 'src/commands/*.json'

concurrency:
group: reply-schemas-linter-${{ github.head_ref || github.ref }}
cancel-in-progress: true

permissions:
contents: read

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/spell-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
push:
pull_request:

concurrency:
group: spellcheck-${{ github.head_ref || github.ref }}
cancel-in-progress: true

permissions:
contents: read

Expand Down

0 comments on commit bfdab65

Please sign in to comment.