Allow delays smaller than 50ms by setting delaybeforesend to None #12
Conversation
|
Thank you again for your contribution! I will fix the CI... |
Thank you. Apologies for not being able to look into the CI issues myself. Thank you for looking into them! |
|
I was afraid CI failed because my tests were not robust enough, but it is actually the PR who broke it :-) 50 means 50 seconds :D 50 seconds to send each character made the action timed out. |
Pexpect added[1] a default delay of 50ms before send, by default, to work around an issue with passwords being echod. This makes it impossible to have delays smaller than this 50ms, currently. This commit allows setting delaybeforesend to None, which is recommended by Pexpect to remove this additional delay hardcoded in Pexpect's code. [1] - https://github.com/pexpect/pexpect/blob/master/pexpect/pty_spawn.py#L136-L150
PierreMarchand20
force-pushed
the
delaybeforesend
branch
from
42ef28b to
5026f54
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Ah! I would've caught it if I used the default with my scripts, but I had already switched to None. Thanks for figuring this out and fixing it! |
Pexpect added[1] a default delay of 50ms before send, by default, to work around an issue with passwords being echod. This makes it impossible to have delays smaller than this 50ms, currently. This commit allows setting delaybeforesend to None, which is recommended by Pexpect to remove this additional delay hardcoded in Pexpect's code.
[1] - https://github.com/pexpect/pexpect/blob/master/pexpect/pty_spawn.py#L136-L150