Improve the check for asciinema start when using --append #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, good point I never use |
Previously, we checked if the tool printed 'recording asciicast to <path>'. This text is only present when the output file is not present, or when an --overwrite flag was passed to asciinema. When the --append flag is used, a different message is printed by asciinema, and this commit checks for that.
PierreMarchand20
approved these changes
Dec 11, 2023
PierreMarchand20
force-pushed
the
append
branch
from
9fc846c to
d67d8b6
Compare
|
Thank you (again) for your contribution! I will publish a new version soon to PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we checked if the tool printed 'recording asciicast to '. This text is only present when the output file is not present, or when an --overwrite flag was passed to asciinema. When the --append flag is used, a different message is printed by asciinema, and this commit checks for that.