Rename and improve BugCheckers used for testing

PicnicSupermarket · Jun 19, 2023 · e0cd928 · e0cd928
1 parent bc7f2ec
commit e0cd928
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/core/src/test/java/com/google/errorprone/refaster/UFreeIdentTest.java b/core/src/test/java/com/google/errorprone/refaster/UFreeIdentTest.java
@@ -49,7 +49,7 @@ public void inlinesExpression() {
 
   @Test
   public void binds() {
-    CompilationTestHelper.newInstance(DummyChecker.class, getClass())
+    CompilationTestHelper.newInstance(UnificationChecker.class, getClass())
         .addSourceLines(
             "A.java",
             "class A {",
@@ -62,10 +62,12 @@ public void binds() {
   }
 
   @BugPattern(
+      name = "UnificationChecker",
       summary = "Verify that unifying the expression results in the correct binding",
       explanation = "For test purposes only",
       severity = SUGGESTION)
-  public static class DummyChecker extends BugChecker implements ExpressionStatementTreeMatcher {
+  public static class UnificationChecker extends BugChecker
+      implements ExpressionStatementTreeMatcher {
     @Override
     public Description matchExpressionStatement(ExpressionStatementTree tree, VisitorState state) {
       Unifier unifier = new Unifier(new Context());

diff --git a/core/src/test/java/com/google/errorprone/refaster/URepeatedTest.java b/core/src/test/java/com/google/errorprone/refaster/URepeatedTest.java
@@ -39,7 +39,7 @@ public class URepeatedTest extends AbstractUTreeTest {
 
   @Test
   public void unifies() {
-    CompilationTestHelper.newInstance(DummyChecker.class, getClass())
+    CompilationTestHelper.newInstance(UnificationChecker.class, getClass())
         .addSourceLines(
             "A.java",
             "class A {",
@@ -52,10 +52,12 @@ public void unifies() {
   }
 
   @BugPattern(
+      name = "UnificationChecker",
       summary = "Verify that unifying the expression results in the correct binding",
       explanation = "For test purposes only",
       severity = SUGGESTION)
-  public static class DummyChecker extends BugChecker implements ExpressionStatementTreeMatcher {
+  public static class UnificationChecker extends BugChecker
+      implements ExpressionStatementTreeMatcher {
     @Override
     public Description matchExpressionStatement(ExpressionStatementTree tree, VisitorState state) {
       Unifier unifier = new Unifier(new Context());