Prevent duplicated rule exception when importing rules and filters #87
Conversation
src/dbt_score/rule_registry.py
Outdated
| @@ -62,6 +62,9 @@ def _load(self, namespace_name: str) -> None: | |||
| module = importlib.import_module(module_name) | |||
| for obj_name in dir(module): | |||
| obj = module.__dict__[obj_name] | |||
| # skip adding objects imported from other modules | |||
There was a problem hiding this comment.
| # skip adding objects imported from other modules | |
| # Skip adding objects imported from other modules |
🤓
There was a problem hiding this comment.
Thanks, should be fixed now.
tests/rules/imported/__init__.py
Outdated
There was a problem hiding this comment.
I don't fully understand why we need a full rules/imported section for this, as we are just fixing a bug. Wouldn't it be simpler to split the existing examples into rules.py and rule_filters.py, add a filter in rule_filters.py that is imported in rules.py? Then it's also a practical use-case that we expect users to have
There was a problem hiding this comment.
Good point, I have split rules/example.py into rules.py and rule_filters.py, and added a rule filter which is now imported into rules.py. The structure should look better now.
tests/test_rule_catalog.py
Outdated
There was a problem hiding this comment.
The ordering of objects has changed, because files were renamed:
exampleused to be beforenested,- now
rulesandrule_filterscome afternested.
|
I will give @matthieucan the final say as he worked on the rule registry |
Co-authored-by: Matthieu Caneill <[email protected]>
Fixes #85.
Implementation
tests/rules/example.pyintotests/rules/rules.pyandtests/rules/rule_filters.py.Duplicatedexception is not raised by adding an importedskip_schemaXrule filter.Note
Both rules and rule filters can be imported now, but the existing tests cover only rule filters.