Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --select option #34

Merged
merged 6 commits into from
May 29, 2024
Merged

Implement --select option #34

merged 6 commits into from
May 29, 2024

Conversation

matthieucan
Copy link
Contributor

When running dbt-score lint, the -s/--select option allows to only lint a selection of models.

When the selection is "simple", i.e. one or multiple model names, a simple filtering of known models is applied. This allows to run it fast.

When the selection is more complex, using dbt's node selection syntax (https://docs.getdbt.com/reference/node-selection/syntax), the filtering is deferred to dbt (dbt ls).

@matthieucan matthieucan self-assigned this May 28, 2024
@matthieucan matthieucan changed the title Matthieucan/select Implement --select option May 28, 2024
Copy link
Contributor

@jochemvandooren jochemvandooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it works like a charm! 🚀

Now we actually have documentation, it would be nice if this feature was mentioned somewhere as this is an important one!

tests/test_models.py Outdated Show resolved Hide resolved
src/dbt_score/models.py Show resolved Hide resolved
Copy link
Contributor

@jochemvandooren jochemvandooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@matthieucan matthieucan merged commit 1dca6c7 into master May 29, 2024
2 checks passed
@matthieucan matthieucan deleted the matthieucan/select branch May 29, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants