Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to get started #25

Merged
merged 7 commits into from
May 27, 2024

Conversation

jochemvandooren
Copy link
Contributor

No description provided.

docs/getting_started.md Outdated Show resolved Hide resolved
Comment on lines 6 to 9
There are two dependencies:

- `dbt-core`: To parse a dbt project.
- `click`: To run the CLI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be in the docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we mention here a general tool purpose? Or will we introduce a separate page for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the general tool purpose is clear from this page


## Installation

The easiest way to install `dbt-score` is with `pip`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other ways? :p

Copy link
Contributor

@druzhinin-kirill druzhinin-kirill May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of pipx? Or do we intend it to be a dev dependency (so pdm/poetry example)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could work for some people, especially if they use dbt without a virtual environment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which brings another point of discussion: dbt-score will pull a version of dbt, as it depends on it. Perhaps we should remove that dependency, and fail the option --run-dbt-parse if no version of dbt can be found in the user environment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the multiple examples, I think it's implied that installing with poetry or pipenv or whatever else will work as well? Feels a little bit redundant IMO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbt-score will pull a version of dbt, as it depends on it. Perhaps we should remove that dependency, and fail the option --run-dbt-parse if no version of dbt can be found in the user environment

This is a good point, but we have to think about dbt-core version dependencies. Not sure if every version will work, because the manifest might have changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! We can check the version at run time though, if we ditch the dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the wording a little bit, I think we can keep it simple.

docs/getting_started.md Outdated Show resolved Hide resolved
docs/getting_started.md Outdated Show resolved Hide resolved
Installation of `dbt-score` is simple:

```shell
pip install dbt-score
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note here about virtual environments? Something like "if you use a virtual environment for dbt, dbt -score should be installed in the same"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

Copy link
Contributor

@matthieucan matthieucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment: let's add somewhere the commands dbt-score --help and dbt-score lint --help :)

@jochemvandooren jochemvandooren merged commit 226cc0a into master May 27, 2024
2 checks passed
@jochemvandooren jochemvandooren deleted the jvandooren/getting-started-documentation branch May 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants