-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation to get started #25
Add documentation to get started #25
Conversation
docs/getting_started.md
Outdated
There are two dependencies: | ||
|
||
- `dbt-core`: To parse a dbt project. | ||
- `click`: To run the CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be in the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we mention here a general tool purpose? Or will we introduce a separate page for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the general tool purpose is clear from this page
docs/getting_started.md
Outdated
|
||
## Installation | ||
|
||
The easiest way to install `dbt-score` is with `pip`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other ways? :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT of pipx
? Or do we intend it to be a dev dependency (so pdm/poetry example)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could work for some people, especially if they use dbt without a virtual environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which brings another point of discussion: dbt-score
will pull a version of dbt, as it depends on it. Perhaps we should remove that dependency, and fail the option --run-dbt-parse
if no version of dbt can be found in the user environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the multiple examples, I think it's implied that installing with poetry
or pipenv
or whatever else will work as well? Feels a little bit redundant IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dbt-score will pull a version of dbt, as it depends on it. Perhaps we should remove that dependency, and fail the option --run-dbt-parse if no version of dbt can be found in the user environment
This is a good point, but we have to think about dbt-core version dependencies. Not sure if every version will work, because the manifest
might have changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! We can check the version at run time though, if we ditch the dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the wording a little bit, I think we can keep it simple.
Installation of `dbt-score` is simple: | ||
|
||
```shell | ||
pip install dbt-score |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a note here about virtual environments? Something like "if you use a virtual environment for dbt, dbt -score should be installed in the same"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment: let's add somewhere the commands dbt-score --help
and dbt-score lint --help
:)
No description provided.