Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit output length of rule generic.columns_have_description #22

Merged
merged 3 commits into from
May 21, 2024

Conversation

matthieucan
Copy link
Contributor

Long (multiline) output can be hard to read.

@matthieucan matthieucan self-assigned this May 21, 2024
message = f"Columns lack a description: {', '.join(invalid_column_names)}."
if len(message) > 60:
message = f"{message[:60]}…"
return RuleViolation(message=message[:90])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why :90?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's a mistake

Copy link
Contributor

@jochemvandooren jochemvandooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@matthieucan matthieucan merged commit ce9a223 into master May 21, 2024
2 checks passed
@matthieucan matthieucan deleted the matthieucan/rule-desc-output branch May 21, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants