Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rule evaluation and scoring #11

Merged
merged 10 commits into from
Apr 19, 2024

Conversation

matthieucan
Copy link
Contributor

Stitch together the manifest (collection of models) and the rule registry (collection of rules) to evaluate every model with every rule defined.
For every model, its score is computed. The aggregation of these scores is also computed in the project score.
Add a human-readable formatter to display those results upon CLI invocation.

Copy link
Contributor

@druzhinin-kirill druzhinin-kirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a first round 🙌

tests/conftest.py Outdated Show resolved Hide resolved
src/dbt_score/evaluation.py Outdated Show resolved Hide resolved
src/dbt_score/evaluation.py Outdated Show resolved Hide resolved
src/dbt_score/evaluation.py Outdated Show resolved Hide resolved
src/dbt_score/evaluation.py Show resolved Hide resolved
Copy link
Contributor

@jochemvandooren jochemvandooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice and works well! 🤩 left a couple of comments

src/dbt_score/models.py Show resolved Hide resolved
src/dbt_score/evaluation.py Outdated Show resolved Hide resolved
src/dbt_score/evaluation.py Outdated Show resolved Hide resolved
src/dbt_score/evaluation.py Outdated Show resolved Hide resolved
tests/formatters/test_human_readable_formatter.py Outdated Show resolved Hide resolved
@matthieucan matthieucan force-pushed the matthieucan/rule-evaluation branch from bc67616 to 582f3e4 Compare April 18, 2024 16:30
Copy link
Contributor

@druzhinin-kirill druzhinin-kirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

@jochemvandooren jochemvandooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@matthieucan matthieucan merged commit 1ced0af into master Apr 19, 2024
2 checks passed
@matthieucan matthieucan deleted the matthieucan/rule-evaluation branch April 19, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants