Bug Fixes and optimisations as a result of issue 106 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to PDO model and correct transactions
SoftKeySets fails with chan_sccp-b prior to revision number 11048. Check the version with the installer, and subsequently to ensure do not get exception.
Switch to PDO model and correct transactions
Simplify structure and fix errors
…sccp_manager into Fix-dbinterface-class
Document changes
Reduce quoting level, and fix errors introduced by prior commits
Use bind param to have stricter typing Fix bug in Sccp-Manager where key and keyword were not the same
Sccpvalues key and keyword must be same or causes hidden DB warnings because of duplicate primary keys after write / read / write
SoftKeySets fails with chan_sccp-b prior to revision number 11048. Check the version with the installer, and subsequently to ensure do not get exception.
Switch to PDO model and correct transactions
Simplify structure and fix errors
Document changes
Reduce quoting level, and fix errors introduced by prior commits
Use bind param to have stricter typing Fix bug in Sccp-Manager where key and keyword were not the same
…sccp_manager into Fix-dbinterface-class
Standardise some calls and add notes
Fix bugs in Response Class causing exceptions Update extconfigs class to correctly check database connectors and improve feedback Move some constructors to start of class for lisibility Tidy up Response class with Typing to eliminate unnecessary tests
Simplify handling of AMI lists and trap exceptions
add 2 new event classes for SCCPShowDevice correct translator in ShowSCCPDevice_Response
Check that have compatible version of chan-sccp for AMI and disable AMI if not found Check returned values Add new classes for response to reduce testing
Before the installer can create sccpsettings, FreePBX instantiates an SCCP_Manager object which requires sccpsettings. Catch the exception and create the table
type declarations must be lowercase or will be treated as local instance names
As per FreePBX BMO, no longer use global db object
Populate sccpdevmodel if empty
Bug fix
String quoting was incompatible with PHP 7
Check that labels exist before binding or an exception will occur
Correct PDO statements and implimentation concept
Correct syntax
|
after puling this PR I've got additional line on "SCCP info" tab:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs in Response Class causing exceptions
Update extconfigs class to correctly check database connectors and improve feedback
Move some constructors to start of class for lisibility
Tidy up Response class with Typing to eliminate unnecessary tests
Issue 106 was due to Asterisk realtime connector errors, which caused exceptions that are resolved by this PR, and extension data in sccp.conf that should not have been there. Now handle correctly even if present.