-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the error message for a missing file #43
base: main
Are you sure you want to change the base?
Conversation
This now attempts to detect misplaced files and provide suggestions about how to resolve the problem if such files are found.
@ShadowLord2005 would be good to get your thoughts on the error message here. |
It looks like it should be alright however do you have some example archives and what they actually output to just see how it reads when looking at a folder structure alongside it? |
The example messages are for an archive with two files -- one in the root called |
Ok, that wasn't what I was thinking it did however it could be that it is clearer with a structure to look at. I think the first part of the message is that is says it couldn't find the file |
In case useful, here's the archive I used for testing: my.zip |
I'm not sure what you mean by "single specific error message". The goal here is to help the user understand what's wrong with the archive they've tried to submit for their code, by adding some guidance for what I believe is the most common error people make -- putting their code in a folder inside the archive rather than just in the root. |
Right, I was thinking that you were going to be doing more case specific error messages. |
Oh, I see. If there's other potential causes for why the file might be missing that we can detect I'm up for adding those too. (Though I can't think of any right now) |
This now attempts to detect misplaced files and provide suggestions about how to resolve the problem if such files are found.
Previously it would have been like:
Now would be like: