Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkgs/dmd): Version 2.096.1 supported #15

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Conversation

dukc
Copy link
Collaborator

@dukc dukc commented Oct 14, 2023

Not that this does much currently, but at least it's a placeholder that we remember this version works.

@PetarKirov PetarKirov force-pushed the oldderivations-port-3 branch from 9bb4106 to 9f5b304 Compare January 28, 2024 20:55
@dukc
Copy link
Collaborator Author

dukc commented Jan 29, 2024

Ah well, time to move this to the supported versions json file instead. Doing it sometime later, trying to find time for it this week.

@dukc dukc marked this pull request as draft January 29, 2024 21:01
@dukc dukc force-pushed the oldderivations-port-3 branch from b1c193b to 54c6ed7 Compare February 3, 2024 20:40
@dukc dukc marked this pull request as ready for review February 3, 2024 20:40
@dukc
Copy link
Collaborator Author

dukc commented Feb 3, 2024

@PetarKirov moved!

This is starting to be in such a good shape that I'm soon going to archive oldDDerivations. Especially the huge wealth of binary packages to pick from here is quite impressive!

@PetarKirov
Copy link
Owner

@PetarKirov moved!

Hey @dukc, thanks, good work 👍. The dmd-2_096_1 | x86_64-linux job is all good, however the x86_64-darwin counterpart is failing. I've pushed a commit to disable the failing tests on dmd's test suite, however now the core.thread.fiber unit tests are segfaulting. To disable them I would probably need to include a patch specific to this version. An alternative solution is to disable the checkPhase entirely. I'll see what I can do. Considering that the same test work on x86_64-darwin works fine with 2.098.1, it maybe the most practical, choice though I'd prefer to avoid it.

This is starting to be in such a good shape that I'm soon going to archive oldDDerivations. Especially the huge wealth of binary packages to pick from here is quite impressive!

I'm very happy to hear that!

@PetarKirov PetarKirov merged commit bbf96c6 into main Feb 5, 2024
64 of 67 checks passed
@PetarKirov PetarKirov deleted the oldderivations-port-3 branch February 5, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants