lib/ExtUtils/MM_Darwin.pm: Unbreak Perl build #444
Conversation
|
Yeah, it looks like the method should just be removed. |
|
Ah ok, propagating |
|
They will be handled properly by the parent method. The extra work was only needed because they were being modified, which is being removed. |
On modern macOS the compiler defaults to '-Werror,-Wimplicit-function-declaration' This breaks the build on code which calls a function without a prototype (invalid in C99). Turning the check off with '-Wno-error=implicit-function-declaration' breaks the build of Perl itself on legacy versions of Darwin with compilers which do not recognise the flags. Removing it allows Perl to once again build on Mac OS X as old as 10.4 with GCC 4.0.1.
|
Method removed. |
|
This is the other half of Perl/perl5#21023. As I commented on that ticket, I think this is generally a good change, but it will break a number of XS modules. The original ticket that added this has some commentary: https://rt.cpan.org/Ticket/Display.html?id=133493. With the upcoming perl 5.38 release, I'm not sure when the best time to make these changes is. |
|
The fixes for the affected modules is a trivial one line fix to prototype each defined function. Is there a list of the modules which break? |
|
There is not - we should probably look into doing some smoke runs to find out. While a fix may be trivial, getting releases done for all of the modules likely won't be. |
On modern macOS the compiler defaults to '-Werror,-Wimplicit-function-declaration' This breaks the build on code which calls a function without a prototype (invalid in C99). Turning the check off with '-Wno-error=implicit-function-declaration' breaks the build of Perl itself on legacy versions of Darwin with compilers which do not recognise the flags. Removing it allows Perl to once again build on Mac OS X as old as 10.4 with GCC 4.0.1.