Improve testing and CI a bit #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
requested changes
Dec 27, 2020
| @@ -45,3 +45,8 @@ jobs: | |||
| run: | | |||
| path C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;%PATH% | |||
| gmake test | |||
| - name: Run Tests | |||
There was a problem hiding this comment.
This should probably have a distinct name.
| my $files = check_dummy_inst('other', 'PREFIX= DESTDIR=other', 'with DESTDIR'); | ||
| eval { | ||
| unlike slurp($files->{'perllocal.pod'}), qr/other/, 'DESTDIR should not appear in perllocal'; | ||
| }; |
There was a problem hiding this comment.
Seems like if there is an exception here, it wouldn't run the test function, which would throw off the text count for the rest of the file.
| @@ -47,3 +47,8 @@ jobs: | |||
| run: | | |||
| path c:\tools\cygwin\bin;c:\tools\cygwin\usr\bin | |||
| make test | |||
| - name: Run Tests | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the CI do
make disttest NOECHO=on all platforms, both to exercise thedisttestfunctionality a bit more, and to reveal what is happening when it doesn't work.Similarly,
t/basic.tis updated so that all runs of the install functionality go via thecheck_dummy_instfunction, which will then always check each install systematically in the same way.