add: loader: injector: Recognize Zygisk modules with API version 5 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerformanC/ReZygisk@2017140 already updated the API to version 5 but the change was not reflected in neither the API header nor the injector Refer to: - topjohnwu/Magisk@e35925d#diff-d2c92e2ebb584ce9600c8e114697bf981c837bcd3f4e80266334a27eacd7dc4eR26 - topjohnwu/Magisk@4931825#diff-919d4ee0afebedf05017af6875ef4ac18daa081de311d4097e8bf3b516f3bcf8R67 Signed-off-by: Paskal Sitepu <[email protected]>
|
That's why the last time I tried using built module from there to test Zygiskd C99 it didn't work 🤣 |
|
Weird they didn't even bring that to Magisk's sample Zygisk module. |
ThePedroo
added
confirmed
Roske13
approved these changes
Nov 22, 2024
|
I'll review it again soon, but I'll likely to approve. However it still confuses me as I haven't seen any update from v4 to v5, and it's not in zygisk-module-sample repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017140 already updated the API to version 5 but the change was not reflected in neither the API header nor the injector
Refer to:
Why
Because modules that use the latest API header found in the latest stable Magisk release are not getting loaded
Checkmarks