Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Allow updating an already inserted image #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abraham
Copy link
Contributor

@abraham abraham commented Nov 16, 2018

Select already inserted image to highlight toolbar button
screenshot from 2018-11-16 11-33-32

Selecting toolbar button opens a window with some options

screenshot from 2018-11-16 11-33-18

Change the values and the image gets updated

screenshot from 2018-11-16 11-34-07

@abraham abraham force-pushed the edit branch 2 times, most recently from d02fd0a to 1161aee Compare November 16, 2018 20:08
@PerfectlyNormal
Copy link
Owner

Hi

I've been waiting with this a little bit, because I'm unsure about the best way to proceed. You change the tooltip/button text, which will cause every other language to not be translated properly, as far as I know. As I don't speak most of them, I'm reluctant to attempt to update the translations myself. But at the same time, the new text describes the functionality better, so changing is probably a good idea.

I'm thinking the best way is probably just to change the translation keys for all the translations, leaving the text as-is, until the original translator or someone else decides they want it changed.

Any thoughts?

@abraham
Copy link
Contributor Author

abraham commented Nov 24, 2018

That seems like the most pragmatic approach. I'm not sure if it's possible with the TinyMCE API but another option would be keeping the current translation and than somehow switching in the edit text if an existing image is selected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants