-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development #8
base: main
Are you sure you want to change the base?
Development #8
Conversation
… comparison in workflow
…message for validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is good, but only gets the last commit. There could be multiple commits that need to be checked since the last tag. I'd suggest getting all commits since the last relevant tag.
.github/workflows/update-readme.yml
Outdated
|
||
steps: | ||
- name: Checkout Caller Repository | ||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should update the actions/checkout version to v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth it to push it to the same branch as triggered the commit rather than a robot-docs
branch, as well as only trigger this one on PR.
We should also find a way to only trigger this one if something changed that affects what goes in the readme. For instance if the join map changed or something like that.
… detailed logging
… streamlined logic
…ndling and generic type support
- Add extract_public_feedbacks function to parse BoolFeedback, IntFeedback, and StringFeedback - Update read_files_in_directory to collect feedback information - Add feedback sections to README.md generation
- Update regex patterns to match property-style feedback declarations - Add support for both field and property-style feedback syntax - Add filtering to clean whitespace from extracted feedback names
- Add support for property-style feedback declarations - Enhance regex patterns to match all feedback formats - Fix feedback detection in C# files with get/private set - Include initialization with equals sign pattern
- Add target directory argument to metadata.py script execution - Add debug output (pwd and ls) to help troubleshoot GitHub workflow - Fix script execution path to work with readme-automation checkout
- Remove redundant workflow repository checkout - Use script directly from workflow repository via github.workspace - Fix target directory path to point to caller's repository root
- Add separate checkouts for caller and workflow repositories - Set working directory to caller's repository - Fix script path to reference workflow repository - Remove debug commands
Add feedbacks
New Features
Additional Fixes and Enhancements