fix: all commands go through the queue #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some instances where any command that responded with a `+OK` and not a value bypassed the command queue. This caused issues, as the subsequent `GET` command to update feedback for a router output WAS enqueued, and responses from subsequent `SET` responses were stepping on the `+OK 0` responses to the `GET` commands. This is especially apparent on RS-232 connections, and probably doesn't present as an issue for SSH connections. ref: #89
|
[X] Updates tested on multiple systems. |
|
accidental close. OK to merge. |
cdenig
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some instances where any command that responded with a
+OKand not a value bypassed the command queue. This caused issues, as the subsequentGETcommand to update feedback for a router output WAS enqueued, and responses from subsequentSETresponses were stepping on the+OK 0responses to theGETcommands. This is especially apparent on RS-232 connections, and probably doesn't present as an issue for SSH connections.fixes #89