Add std:: to some usual suspects #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
AmintorDusko
added
do not merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #865 +/- ##
==========================================
- Coverage 98.33% 98.32% -0.02%
==========================================
Files 114 148 +34
Lines 19157 23391 +4234
==========================================
+ Hits 18838 22999 +4161
- Misses 319 392 +73 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
AmintorDusko
added
the
ci:use-multi-gpu-runner
vincentmr
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
LGTM, thanks @AmintorDusko . Don't forget to update the changelog.
Co-authored-by: Luis Alfredo Nuñez Meneses <[email protected]>
Co-authored-by: Luis Alfredo Nuñez Meneses <[email protected]>
LuisAlfredoNu
approved these changes
Aug 26, 2024
multiphaseCFD
approved these changes
Aug 26, 2024
multiphaseCFD
pushed a commit
that referenced
this pull request
Sep 8, 2024
**Context:** We have several occurrences of missing std namespace. **Description of the Change:** Add std namespace to usual suspects. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-71935] --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Luis Alfredo Nuñez Meneses <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We have several occurrences of missing std namespace.
Description of the Change: Add std namespace to usual suspects.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-71935]