Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 24 CI: Remove libopenblas-base package and update Kokkos build OS #1041

Merged
merged 9 commits into from
Jan 17, 2025

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Jan 16, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Github Ubuntu CI has upgraded from 22 to 24, and libopenblas-base package is no longer present (leads to failure) and needed.

Description of the Change:
Removed libopenblas-base package installation for CI tests.

Since ubuntu24 ship with a new version of gcov, when using GCC11/12, we will get errors like these:

runner_measurements.cpp.gcno:version 'B14*', prefer 'B33*'
geninfo: ERROR: Incompatible GCC/GCOV version found while processing /home/runner/work/pennylane-lightning/pennylane-lightning/Build/pennylane_lightning/core/src/measurements/tests/CMakeFiles/measurements_test_runner.dir/runner_measurements.cpp.gcda:
	Your test was built with 'B14*'.
	You are trying to capture with gcov tool '/usr/bin/gcov' which is version 'B33*'.
	(use "geninfo --ignore-errors version ..." to bypass this error)

With GCC13, lcov will fail with:

geninfo: ERROR: mismatched end line for _Z43C_A_T_C_H_T_E_M_P_L_A_T_E_T_E_S_T_F_U_N_C_0IdEvv at /pennylane-lightning/pennylane_lightning/core/src/utils/tests/Test_Util.cpp:32: 32 -> 49
        (use "geninfo --ignore-errors mismatch ..." to bypass this error)

I have checked that the coverage % is still correct with adding --ignore-errors mismatch

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-82360]

@josephleekl josephleekl marked this pull request as ready for review January 16, 2025 20:22
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (bfaa2bb) to head (0da48ef).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (bfaa2bb) and HEAD (0da48ef). Click for more details.

HEAD has 76 uploads less than BASE
Flag BASE (bfaa2bb) HEAD (0da48ef)
83 7
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
- Coverage   98.19%   91.87%   -6.32%     
==========================================
  Files         233      177      -56     
  Lines       39070    27346   -11724     
==========================================
- Hits        38363    25125   -13238     
- Misses        707     2221    +1514     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephleekl for your swift fix!

.github/workflows/tests_linux_cpp.yml Outdated Show resolved Hide resolved
.github/workflows/tests_linux_cpp.yml Show resolved Hide resolved
.github/workflows/tests_linux_cpp.yml Show resolved Hide resolved
@josephleekl josephleekl changed the title Remove libopenblas-base package for Ubuntu 24 CI Ubuntu 24 CI: Remove libopenblas-base package and update Kokkos build OS Jan 17, 2025
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @josephleekl! Please check latest/latest before merging the PR 🥳

.github/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @josephleekl .

@josephleekl josephleekl merged commit 7f2d585 into master Jan 17, 2025
74 of 75 checks passed
@josephleekl josephleekl deleted the ubuntu-blas branch January 17, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants