-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 24 CI: Remove libopenblas-base package and update Kokkos build OS #1041
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 98.19% 91.87% -6.32%
==========================================
Files 233 177 -56
Lines 39070 27346 -11724
==========================================
- Hits 38363 25125 -13238
- Misses 707 2221 +1514 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @josephleekl for your swift fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @josephleekl! Please check latest/latest before merging the PR 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @josephleekl .
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Github Ubuntu CI has upgraded from 22 to 24, and libopenblas-base package is no longer present (leads to failure) and needed.
Description of the Change:
Removed libopenblas-base package installation for CI tests.
Since ubuntu24 ship with a new version of gcov, when using GCC11/12, we will get errors like these:
With GCC13, lcov will fail with:
I have checked that the coverage % is still correct with adding
--ignore-errors mismatch
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-82360]