Optimized Ion Dialect to minimize redundant code in IonOp #1471
+49
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul0403
added
author:build-wheels
paul0403
approved these changes
Jan 21, 2025
|
I was reading the openapl grammar and noticed that they actually keep a (required) string label for a level in their IR as well! So I'd say this change accomplishes more than we originally thought, and actually helps with the openapl generation! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The current design of the IonOp redefines all the level attributes of a transition from scratch, which is quite inefficient when lowering to llvm IR. This can be optimized by labeling the pre-defined levels (upstate, downstate, estate) and just referencing them in the transition attribute.
Description of the Change:
Added a string attribute
labelto Level.Changed the levels of a transition from
LevelAttrtostringBenefits:
Can reference the label of a level instead redefining the level attribute with all its parameters which results in reduced code size.
Possible Drawbacks:
Related GitHub Issues: