-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dep version parsing #1461
Conversation
Use regular expressions rather than string splitting for improved robustness and to allow for deps to be commented out.
Hello. You may have forgotten to update the changelog!
|
There are failures using the Lightning Kokkos backend, I think because the CI action is pinning |
The PL min release in setup.py was input as a float when it should have been input as a string. For example, `release = 0.40` is interpreted as `release = 0.4`, which is not the same!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏
Context: At the end of a release cycle, it would be convenient to comment out the pennylane and lightning versions in the
.dep-versions
file, as so:This allows keeping the correct format in place without explicitly pinning the package version. However, comments are not currently recognized when the
.dep-versions
file is parsed insetup.py
.Description of the Change: Replace the old file parsing, which performed simple string splitting based on the number of characters after
jax=
,pennylane=
andlightning=
, with more robust regex-based parsing that also allows for lines to be commented out.The pennylane and lightning versions introduced at the end of the PennyLane/Lightning 0.40.0 release cycle have also been commented out.