-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QNode.execute_kwargs
no longer has mcm_config
key
#1452
base: main
Are you sure you want to change the base?
Conversation
QNode.execute_kwargs
no longer has "mcm_config"
key
QNode.execute_kwargs
no longer has "mcm_config"
keyQNode.execute_kwargs
no longer has mcm_config
key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrijapau !
Hello. You may have forgotten to update the changelog!
|
@dime10, does this need to be in the changelog? 🙇🏼♂️ |
It's alright from my side, but if you want to add it you can do it in the |
Context:
PennyLaneAI/pennylane#6807 deprecates
mcm_config
as an argument toqml.execute
. Instead it is designed to have signature parity withQNode
, instead accepting bothpostselect_mode
andmcm_method
as arguments and creating aMCMConfig
internally.❗ As a side-effect,
QNode.execute_kwargs
no longer has amcm_config
key.This PR updates Catalyst source code to reflect that.
Description of the Change:
Use
postselect_mode
andmcm_method
keys forQNode.execute_kwargs
instead ofmcm_config
.Benefits: Signature parity with
QNode
and better testing capabilities.Possible Drawbacks: None identified.
[sc-80541]