Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QNode.execute_kwargs no longer has mcm_config key #1452

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Jan 13, 2025

Context:

PennyLaneAI/pennylane#6807 deprecates mcm_config as an argument to qml.execute. Instead it is designed to have signature parity with QNode, instead accepting both postselect_mode and mcm_method as arguments and creating a MCMConfig internally.

❗ As a side-effect, QNode.execute_kwargs no longer has a mcm_config key.

This PR updates Catalyst source code to reflect that.

Description of the Change:

Use postselect_mode and mcm_method keys for QNode.execute_kwargs instead of mcm_config.

Benefits: Signature parity with QNode and better testing capabilities.

Possible Drawbacks: None identified.

[sc-80541]

@andrijapau andrijapau changed the title fix: Update files that still use mcm_config as key to exec_kwargs QNode.execute_kwargs no longer has "mcm_config" key Jan 13, 2025
@andrijapau andrijapau changed the title QNode.execute_kwargs no longer has "mcm_config" key QNode.execute_kwargs no longer has mcm_config key Jan 13, 2025
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrijapau !

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@andrijapau andrijapau requested a review from a team January 14, 2025 21:16
@andrijapau
Copy link
Contributor Author

@dime10, does this need to be in the changelog? 🙇🏼‍♂️

@dime10
Copy link
Contributor

dime10 commented Jan 14, 2025

@dime10, does this need to be in the changelog? 🙇🏼‍♂️

It's alright from my side, but if you want to add it you can do it in the Internal Changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants