-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements in catalyst cli docs, option help, and intermediate file naming #1405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, these are great improvements 🚀 🚀
I'm happy to merge as is, although for the help output I still wonder if we couldn't put the mlir-opt
output behind an additional option, like --help-passes
, --help-opt
, --help-tool
or something like that. The main --help
option can then point out that there are additional help pages. It's just such a slog to scroll through all the output.
**Context:** Preparing the main branch for Catalyst v0.11.0-dev (development release). **Description of the Change:** Bump version to "0.11.0-dev" and add new changelog. --------- Co-authored-by: erick-xanadu <[email protected]>
**Context:** The new development release is v0.11.0, not v0.10.0. :confounded: **Description of the Change:** Fix typo in title of changelog for development release.
@mehrdad2m and @dime10, do we want to get this in for the release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mehrdad2m! Just had a few editorial suggestions.
Hi @joeycarter Yes I think it should be in the release. On my side it is ready to be merged. I can merged it after addressing your comments |
Great, thanks! In that case, can you move the changelog entry to |
Co-authored-by: David Ittah <[email protected]>
Co-authored-by: David Ittah <[email protected]>
Co-authored-by: Joey Carter <[email protected]>
4b11431
to
0e5ad37
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.10.0-rc #1405 +/- ##
==============================================
+ Coverage 96.68% 96.91% +0.23%
==============================================
Files 75 58 -17
Lines 8266 6880 -1386
Branches 867 796 -71
==============================================
- Hits 7992 6668 -1324
+ Misses 221 159 -62
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Context:
This PR fixes some small bugs or lack of documentation for catalyst-cli gathered from @dime10's feedbacks.
The
--help
flag seems to dump a lot of unrelated options which makes it difficult to navigate through catalyst options.The possible stages for the --checkpoint-stage option are not mentioned in the documentation
When using
--checkpoint-stage
,--save-ir-after-each=pipeline
no longer works.The output from --save-ir-after-each=pass produces one output for each function when dealing with a function pass which results in a large number of outputs and one has to find the function of interest randomly.
Description of the Change:
--help
option now prints all the catalyst-cli specific options first before jumping into mlir-opt optionsAdded more details to documentation
Fixed the bug for
save-ir-after-each
andsave-ir-after-each
coexisting together.Output from
save-ir-after-each
now appends the name of the function to the file name making it easier to identify the desired output.Benefits:
easier experience for catalyst-cli user
Possible Drawbacks:
Related GitHub Issues: