-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert openblas linking changes from #451 #1386
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @dime10
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
- Coverage 96.72% 95.82% -0.91%
==========================================
Files 78 78
Lines 8439 8437 -2
Branches 873 873
==========================================
- Hits 8163 8085 -78
- Misses 222 299 +77
+ Partials 54 53 -1 ☔ View full report in Codecov by Sentry. |
@dime10 there were some documentation changes to reflect support for finite shot measurements of hermitian observables. If this comes into effect, we should also revert those documentation changes. |
Well in theory they are supported simply by upgrading the version of lightning (which will be forced by next release anyway) 🤔 The original PR had no functional changes on the catalyst side besides the erroneous linking. We could consider it a known issue on macos that the lapack libs may clash, and try to resolve it in a follow up? |
Having said that it might not be possible to merge this if the failure is reproducible in the CI. |
Just waiting on the lightning wheels to become available and we should be able to merge this! |
PR #451 introduced linking against both OpenBLAS and LAPACKE+Accelerate on arm macOS, which breaks re-compilation of certain user programs (like Shor's). The cause of the shared library conflict is unknown.
For now, we revert these linking changes, which were originally introduced due to Lightning not finding its OpenBLAS dependency when invoked through Catalyst:
The above test will fail as a result of this, which we plan to fix with a PR on the lightning side.
[sc-80803]