Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official recon spec for ss3t FOD autotrack #196

Merged
merged 20 commits into from
Dec 17, 2024

Conversation

mattcieslak
Copy link
Contributor

Building on #194 this adds an actual workflow for using mrtrix CSD FODs for autotrack.

@mattcieslak mattcieslak changed the title Enh/fod autotrack real Add official recon spec for ss3t FOD autotrack Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 53.27103% with 50 lines in your changes missing coverage. Please review.

Project coverage is 48.68%. Comparing base (f95211a) to head (cbdbc73).

Files with missing lines Patch % Lines
qsirecon/interfaces/converters.py 27.77% 39 Missing ⚠️
qsirecon/interfaces/dsi_studio.py 22.22% 7 Missing ⚠️
qsirecon/workflows/recon/build_workflow.py 90.00% 0 Missing and 2 partials ⚠️
qsirecon/workflows/recon/converters.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   48.57%   48.68%   +0.11%     
==========================================
  Files          56       56              
  Lines        7309     7405      +96     
  Branches      999     1013      +14     
==========================================
+ Hits         3550     3605      +55     
- Misses       3543     3583      +40     
- Partials      216      217       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of recommendations for formatting and documentation, but I didn't see anything problematic in the code.

qsirecon/interfaces/converters.py Show resolved Hide resolved
qsirecon/interfaces/converters.py Show resolved Hide resolved
qsirecon/workflows/recon/converters.py Outdated Show resolved Hide resolved
qsirecon/workflows/recon/converters.py Outdated Show resolved Hide resolved
qsirecon/workflows/recon/dsi_studio.py Outdated Show resolved Hide resolved
docs/builtin_workflows.rst Outdated Show resolved Hide resolved
qsirecon/interfaces/converters.py Show resolved Hide resolved
@mattcieslak mattcieslak merged commit 8b76ea3 into main Dec 17, 2024
26 checks passed
@mattcieslak mattcieslak deleted the enh/fod-autotrack-real branch December 17, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants