Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space in ds_qsiprep_5tt_hsvs #175

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Fix space in ds_qsiprep_5tt_hsvs #175

merged 4 commits into from
Nov 20, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 19, 2024

Closes none, but addresses a bug identified by @araikes.

Changes proposed in this pull request

  • Hardcode space entity in ds_qsiprep_5tt_hsvs as ACPC, not T1w.

@tsalo
Copy link
Member Author

tsalo commented Nov 19, 2024

@mattcieslak should I also change the T1w default here?

def init_discard_repeated_samples_wf(
inputs_dict,
name="discard_repeats",
qsirecon_suffix="",
space="T1w",
params={},
):

The space parameter isn't actually used, so it might be better to just remove it.

@tsalo tsalo added the bug Something isn't working label Nov 19, 2024
@mattcieslak
Copy link
Contributor

The space parameter isn't actually used, so it might be better to just remove it.

I think we should remove it

Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tsalo
Copy link
Member Author

tsalo commented Nov 19, 2024

I'm pretty sure the hsvs test is going to fail, but I also noticed other cases where we have T1w.

@tsalo tsalo requested a review from mattcieslak November 19, 2024 21:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.94%. Comparing base (8545323) to head (c280cb7).

Files with missing lines Patch % Lines
qsirecon/interfaces/scalar_mapping.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   33.94%   33.94%           
=======================================
  Files          57       57           
  Lines        7195     7195           
  Branches      983      983           
=======================================
  Hits         2442     2442           
  Misses       4655     4655           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those spaces in the csv file may be coming from here.

@tsalo tsalo merged commit 3746cf7 into main Nov 20, 2024
24 checks passed
@tsalo tsalo deleted the fix-hsvs-space branch November 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants