-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix space in ds_qsiprep_5tt_hsvs #175
Conversation
@mattcieslak should I also change the T1w default here? qsirecon/qsirecon/workflows/recon/utils.py Lines 54 to 60 in c1b8435
The space parameter isn't actually used, so it might be better to just remove it. |
I think we should remove it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm pretty sure the hsvs test is going to fail, but I also noticed other cases where we have T1w. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage 33.94% 33.94%
=======================================
Files 57 57
Lines 7195 7195
Branches 983 983
=======================================
Hits 2442 2442
Misses 4655 4655
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those spaces in the csv file may be coming from here.
Closes none, but addresses a bug identified by @araikes.
Changes proposed in this pull request
ds_qsiprep_5tt_hsvs
as ACPC, not T1w.