Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HBCD Release1 recon workflow #169

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

mattcieslak
Copy link
Contributor

@mattcieslak mattcieslak commented Nov 19, 2024

Closes #168.

The constants in NODDI may not be appropriate for infants, so we are removing NODDI from the hbcd_scalar_maps recon spec.

Documentation is also updated for other recon workflows

@mattcieslak mattcieslak requested a review from tsalo November 19, 2024 18:14
@tsalo tsalo added the enhancement New feature or request label Nov 19, 2024
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for my one comment.

@tsalo
Copy link
Member

tsalo commented Nov 19, 2024

One minor thing about PR titles and release notes- GitHub will organize this PR under "New Features" because I added the "enhancement" label, but the "new feature" will be the PR title, so it would be nice to make the actual title a bit more detailed and to drop the [ENH] prefix.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.94%. Comparing base (46b699d) to head (c8e8bbc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   33.94%   33.94%           
=======================================
  Files          57       57           
  Lines        7195     7195           
  Branches      983      983           
=======================================
  Hits         2442     2442           
  Misses       4655     4655           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mattcieslak mattcieslak merged commit 2a3b2de into main Nov 19, 2024
24 checks passed
@tsalo tsalo deleted the enh/hbcd-scalar-map-refine branch November 19, 2024 18:58
@tsalo tsalo changed the title [ENH] update hbcd to exclude noddi Add HBCD Release1 recon workflow Nov 20, 2024
@tsalo tsalo added this to the HBCD milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HBCD Release1 recon workflow
3 participants