-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused transform connections #889
Conversation
"A004", # TODO: Fix these | ||
"B006", # TODO: Fix these | ||
"S607", # TODO: Fix these | ||
"S108", # TODO: Fix these | ||
"S602", # TODO: Fix these | ||
"E402", # TODO: Fix these | ||
"UP028", # TODO: Fix these | ||
"UP031", # TODO: Fix these | ||
"BLE001", # TODO: Fix these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why new style issues are suddenly cropping up. It looks like ruff was just missing them before. My local version isn't catching them either.
# Only place a template transform is used on DWI data | ||
('t1_2_mni_reverse_transform', 'inputnode.t1_2_mni_reverse_transform'), | ||
('b0_ref', 'inputnode.bold_ref'), | ||
('template', 'inputnode.template'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to note this. When we switch to --output-spaces
, we should (1) raise an error if users try to use syn with infant data and (2) only pass along the 2009c template transform here.
This makes me think that we should track through the workflow connections across the package and drop any that are unused. @mattcieslak WDYT? |
I think we will actually need most of these once we add the synb0-disco method |
I thought SynB0's requirements were basically the same as syn's. Is that not the case? |
Closes none. I'm attempting to remove any unused connections that might interfere with #681.
Changes proposed in this pull request