Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problems processing Mulit-Echo images #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

holderg
Copy link

@holderg holderg commented Apr 17, 2024

Seimann's software now (2/1/2024) produces Multi-Echo images. The flywheel representation for these images are not compatible with nibabel.

It seems that nibabel was only being used to get the number of rows and columns in the images. Removed dependency on nibabel and now get the row and column numbers directly from the flywheel image metadata.

-Gaylord

gholder added 2 commits April 17, 2024 15:19
Seimann's software now (2/1/2024) produces MulitPath Echo images.  The flywheel representation
for these images are not combatible with nibabel.

It seems that nibabel was only being used to get the number of rows and columns in the images.  Removed
dependancy on nibabel and get the row and column numbers directly from the flywheel image metadata.

-Gaylord
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a PR with the fix! only suggestion is to not include merge conflict tags in comments, you should be able to add the changes directly from the PR

@@ -29,11 +29,11 @@ fi
echo Uploading to pip...

python setup.py sdist
<<<<<<< HEAD
#<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#<<<<<<< HEAD
#<<<<<<< HEAD

Comment on lines +34 to 37
#=======
#twine upload --skip-existing dist/*
#>>>>>>> 451d0170cd190ca6cceb86def6dc51bc45a73802

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#=======
#twine upload --skip-existing dist/*
#>>>>>>> 451d0170cd190ca6cceb86def6dc51bc45a73802

},
"command": "./fw_heudiconv_run.py",
"author": "Tinashe Michael Tapera",
"maintainer": "Tinashe Michael Tapera",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be interested in being listed as maintainer here? Tinashe has left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants