Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing e2e slurm tests #169

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Introducing e2e slurm tests #169

merged 6 commits into from
Feb 28, 2024

Conversation

asmacdo
Copy link
Collaborator

@asmacdo asmacdo commented Jan 26, 2024

This PR introduces a full e2e test that loosely corresponds with the example walkthrough

To do this, we use a SLURM "microcluster" run inside a container.

TODO:

@asmacdo
Copy link
Collaborator Author

asmacdo commented Jan 26, 2024

Not sure why the new tests didn't run here, they did run on my fork

https://github.com/asmacdo/babs/actions/runs/7670941389/job/20908224578

@yarikoptic
Copy link
Collaborator

may be because it is a new workflow and there are some secrets so github isn't running it by default for external contributors? but overall -- dunno.

@asmacdo asmacdo marked this pull request as ready for review February 20, 2024 17:40
@mattcieslak mattcieslak merged commit a9c1aa7 into PennLINC:main Feb 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants