Replace legacy validator with schema validator #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also change cubids print-metadata-fields to account for json file errors due to not been validated yet
tsalo
reviewed
Nov 18, 2024
tsalo
reviewed
Nov 18, 2024
gabridele
added a commit
to gabridele/CuBIDS_
that referenced
this pull request
Nov 25, 2024
…quest of original repo
tsalo
reviewed
Dec 12, 2024
|
It looks like the coverage report isn't being uploaded. I think the repo might need a token to upload, or maybe it's just misconfigured for tokenless uploading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #336.
Changes proposed in this pull request
cubids print-metadata-fieldsto account for json file errors due to not been validated yetcubids bids-versionto either print or save validator and schema version + add unit test for this functionDocumentation that should be reviewed