Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary arguments from cubids apply #317

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jun 3, 2024

Closes #314.

Changes proposed in this pull request

  • Remove the function parameters edited_tsv_prefix and output_prefix from cubids.workflows.apply(). The prefixes will be inferred from edited_summary_tsv and new_tsv_prefix, respectively.

@tsalo tsalo added the bug Something isn't working label Jun 3, 2024
@tsalo tsalo requested a review from mattcieslak June 3, 2024 15:36
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the just fixing the docker/singularity wrapper?

@tsalo
Copy link
Member Author

tsalo commented Jun 4, 2024

No it should fix the command-line interface since those two were required arguments to the workflow function that weren't being provided by the CLI.

@tsalo tsalo merged commit fd7c252 into PennLINC:main Jun 4, 2024
8 checks passed
@tsalo tsalo deleted the fix-cubids-apply branch June 4, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

what is the correct usage of cubids apply?
2 participants